Build error while adding debug LL support for new board

[Mohammed, Afzal]

Hi Russell,

n Mon, Oct 17, 2011 at 18:30:32, Mohammed, Afzal wrote:
> Hi, Russell,
> 
> While adding low level debug support for new board in OMAP2+ family, we
> came across following error,
> 
> arch/arm/kernel/debug.S: Assembler messages:
> arch/arm/kernel/debug.S:138: Error: invalid constant (428) after fixup
> 
> Following patch fixes it, I am not sure whether this is the right fix,
> please let us know your comments.

ping

Regards
Afzal

> From: Afzal Mohammed <afzal at ti.com>
> Date: Fri, 14 Oct 2011 12:56:16 +0530
> Subject: [PATCH] ARM: Fix error upon adding LL debug
> 
> Upon adding new board LL debug support, if the resultant code
> addition would not cause PC relative offset of "hexbuf" from
> "adr r2, hexbuf" (+2) instruction to be representable in a
> shifted 8-bit value (hence indirectly putting higher aligment
> requirement on larger offsets), following error occurs,
> 
> arch/arm/kernel/debug.S: Assembler messages:
> arch/arm/kernel/debug.S:138: Error: invalid constant (428) after fixup
> 
> Fix it by bringing "hexbuf" closer so that "adr"
> can have the offset.
> 
> Signed-off-by: Afzal Mohammed <afzal at ti.com>
> ---
>  arch/arm/kernel/debug.S |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/kernel/debug.S b/arch/arm/kernel/debug.S
> index bcd66e0..0f852d0 100644
> --- a/arch/arm/kernel/debug.S
> +++ b/arch/arm/kernel/debug.S
> @@ -151,6 +151,8 @@ printhex:   adr     r2, hexbuf
>                 b       printascii
>  ENDPROC(printhex2)
> 
> +hexbuf:                .space 16
> +
>                 .ltorg
> 
>  ENTRY(printascii)
> @@ -175,5 +177,3 @@ ENTRY(printch)
>                 mov     r0, #0
>                 b       1b
>  ENDPROC(printch)
> -
> -hexbuf:                .space 16
> --
> 1.6.2.4
> 
> 
>