[PATCH 3/9] ARM: SPMP8000: Add clk support

Zoltan Devai zdevai at gmail.com
Sun Oct 16 10:16:45 EDT 2011


2011/10/13 Russell King - ARM Linux <linux at arm.linux.org.uk>:
> On Sun, Oct 09, 2011 at 06:36:06PM +0200, Zoltan Devai wrote:
>> --- /dev/null
>> +++ b/arch/arm/mach-spmp8000/clkdev.c
...
>> +#include <mach/scu.h>
>
> I find the use of 'scu' for something which isn't the SMP Coherence Unit
> rather confusing - and I suspect you will too if/when spmp8000 has SMP
> support.
Well, Sunplus decided to name these devices 'SCU', which are a collection
of reset, clock, debug, pinmux and gpio stuff.
The datasheet doesn't even tell what SCU stands for, but I'd prefer to keep
the naming to be in sync with the documentation.

I'll fix the issues pointed out by your other comments in the next version.

Thanks,
Zoltan



More information about the linux-arm-kernel mailing list