[PATCH v2 01/14] ARM: tegra: annotate IO_*_VIRT pointers

Olof Johansson olof at lixom.net
Thu Oct 13 18:27:13 EDT 2011


On Thu, Oct 13, 2011 at 7:10 AM, Russell King - ARM Linux
<linux at arm.linux.org.uk> wrote:
> On Sun, Oct 09, 2011 at 10:27:51PM -0700, Olof Johansson wrote:
>> +#ifdef __ASSEMBLY__
>> +#define __IOVADDR(x) (x)
>> +#else
>> +#define __IOVADDR(x) ((void __force __iomem *)(x))
>
> Please call this IOMEM() - see:
>
> grep '#define *IOMEM' arch/arm/*/include/mach -r
>
> for its establishment across several implementations.


Ah, thanks! I did look for a pre-existing one, but not closely enough.
I've revised the patch and will send a fresh pull request to Arnd with
the new contents.

I suppose there is some value in doing a global variant of this
instead of having it redefined on all platforms. I'll add it to the
list of cleanups to look at.


-Olof



More information about the linux-arm-kernel mailing list