[PATCH v4 3/4] gpio/tegra: Convert to a platform device

Grant Likely grant.likely at secretlab.ca
Wed Oct 12 19:08:57 EDT 2011

On Tue, Oct 11, 2011 at 4:16 PM, Stephen Warren <swarren at nvidia.com> wrote:
> v3: Make regs variable static. Remove empty init of tegra_gpio_banks.
> v2: Retrieve IRQ and memory addresses from resources instead of hard-
> coding them. Add back initialization of tegra_gpio_chip.of_node.
> Signed-off-by: Stephen Warren <swarren at nvidia.com>

Acked-by: Grant Likely <grant.likely at secretlab.ca>

One comment below however.

> @@ -333,28 +335,55 @@ static struct irq_chip tegra_gpio_irq_chip = {
>  */
>  static struct lock_class_key gpio_lock_class;
> -static int __init tegra_gpio_init(void)
> +static int __init tegra_gpio_probe(struct platform_device *pdev)

__devinit because this is put in the .probe hook of the driver.


More information about the linux-arm-kernel mailing list