[PATCH] ARM: kprobes: only patch instructions on one CPU
Rabin Vincent
rabin at rab.in
Wed Oct 12 12:12:24 EDT 2011
The text patching needs to be done only once, instead of once on each
CPU. The other CPUs will busy wait inside the stop machine code until
the patching is done.
Cc: Jon Medhurst <tixy at yxit.co.uk>
Cc: Nicolas Pitre <nicolas.pitre at linaro.org>
Signed-off-by: Rabin Vincent <rabin at rab.in>
---
arch/arm/kernel/kprobes.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/kernel/kprobes.c b/arch/arm/kernel/kprobes.c
index 129c116..e9f95300 100644
--- a/arch/arm/kernel/kprobes.c
+++ b/arch/arm/kernel/kprobes.c
@@ -127,7 +127,7 @@ void __kprobes arch_arm_kprobe(struct kprobe *p)
flush_insns(addr, sizeof(u16));
} else if (addr & 2) {
/* A 32-bit instruction spanning two words needs special care */
- stop_machine(set_t32_breakpoint, (void *)addr, &cpu_online_map);
+ stop_machine(set_t32_breakpoint, (void *)addr, NULL);
} else {
/* Word aligned 32-bit instruction can be written atomically */
u32 bkp = KPROBE_THUMB32_BREAKPOINT_INSTRUCTION;
@@ -190,7 +190,7 @@ int __kprobes __arch_disarm_kprobe(void *p)
void __kprobes arch_disarm_kprobe(struct kprobe *p)
{
- stop_machine(__arch_disarm_kprobe, p, &cpu_online_map);
+ stop_machine(__arch_disarm_kprobe, p, NULL);
}
void __kprobes arch_remove_kprobe(struct kprobe *p)
--
1.7.5.4
More information about the linux-arm-kernel
mailing list