[PATCH 2/2] pinmux: add a driver for the U300 pinmux

[Barry Song]

2011/10/10 Linus Walleij <linus.walleij at linaro.org>:
> On Sat, Oct 8, 2011 at 11:09 AM, Barry Song <21cnbao at gmail.com> wrote:
>>> +static void __init u300_pmx_dumpregs(struct u300_pmx *upmx)
>>> +{
>>> +       u16 regval;
>>> +       int i;
>>> +
>>> +       for (i = 0; i < ARRAY_SIZE(u300_pmx_registers); i++) {
>>> +               regval = readw(upmx->virtbase + u300_pmx_registers[i]);
>>> +               dev_info(upmx->dev, "PMX%u: 0x%04x\n", i, regval);
>>> +       }
>>> +}
>>
>> is this a debug information or do you want it to be in mainline?
>
> Debug info, I'll delete it. Not that it hurt, but I'll kill it.
>
>>> +       /* Create state holders etc for this driver */
>>> +       upmx = devm_kzalloc(&pdev->dev, sizeof(struct u300_pmx), GFP_KERNEL);
>>
>> and this would be "devm_kzalloc(&pdev->dev, sizeof(*upmx), GFP_KERNEL); " ?
>
> Same semantic effect, but if you prefer it that way, sure :-)
>
> I've seen both used in the kernel before...

coding style document says :
"
                  Chapter 14: Allocating memory

  The kernel provides the following general purpose memory allocators:
  kmalloc(), kzalloc(), kcalloc(), vmalloc(), and vzalloc().  Please refer to
  the API documentation for further information about them.

 The preferred form for passing a size of a struct is the following:

          p = kmalloc(sizeof(*p), ...);

  The alternative form where struct name is spelled out hurts readability and
  introduces an opportunity for a bug when the pointer variable type is changed
  but the corresponding sizeof that is passed to a memory allocator is not.
"
>
> Can I have your Reviewed-by: tag after this?

yes. of course.

>
> Linus Walleij
>
Thanks
barry