[PATCH 1/3] ARM: imx: always select CACHE_L2X0 on i.MX3
Barry Song
21cnbao at gmail.com
Sun Oct 9 01:44:01 EDT 2011
2011/10/9 Shawn Guo <shawn.guo at freescale.com>:
> On Sat, Oct 08, 2011 at 05:15:50PM +0200, Arnd Bergmann wrote:
>> The i.MX3 and i.MX35 files unconditionally call the l2x0_init
>> function, so we should make sure that this is built into the
>> kernel.
>>
>> arch/arm/mach-imx/built-in.o: In function `imx3_init_l2x0':
>> mm-imx3.c:(.text+0x154): undefined reference to `l2x0_init'
>>
>> Signed-off-by: Arnd Bergmann <arnd at arndb.de>
>> ---
>
> Acked-by: Shawn Guo <shawn.guo at linaro.org>
>
> However, this should also be fixed by the Rob Herring's patch below
> which I suppose it will be merged in the coming window.
>
> ARM: l2x0: add empty l2x0_of_init
>
> Anyway, your change makes sense to me, as the SoCs have L2 integrated
> and I see no reason that L2 can not be selected by default. I will
> do the same for my imx6q series to remove the dependency on Rob's
> patch.
the only loss is that users have to change Kconfig if they don't want
to open L2 for debugging purpose.
>
> Regards,
> Shawn
>
>> arch/arm/mach-imx/Kconfig | 3 ++-
>> 1 files changed, 2 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
>> index 6c12836..3de9ac9 100644
>> --- a/arch/arm/mach-imx/Kconfig
>> +++ b/arch/arm/mach-imx/Kconfig
>> @@ -64,6 +64,7 @@ config SOC_IMX31
>> select ARCH_MXC_AUDMUX_V2
>> select ARCH_MX31
>> select MXC_AVIC
>> + select CACHE_L2X0
>>
>> config SOC_IMX35
>> bool
>> @@ -73,7 +74,7 @@ config SOC_IMX35
>> select HAVE_EPIT
>> select ARCH_MX35
>> select MXC_AVIC
>> -
>> + select CACHE_L2X0
>>
>> if ARCH_IMX_V4_V5
>>
>> --
>> 1.7.5.4
-barry
More information about the linux-arm-kernel
mailing list