[PATCH] mx5: modify pm and idle

Shawn Guo shawn.guo at freescale.com
Fri Oct 7 22:06:10 EDT 2011


On Sat, Oct 08, 2011 at 09:34:43AM +0800, Hui Wang wrote:
> Sascha Hauer wrote:
> >On Fri, Sep 30, 2011 at 02:37:22PM +0800, Hui Wang wrote:
> >>Two problems exist in the current i.MX5 pm suspend/resume and idle
> >>functions. The first is the current i.MX5 suspend routine will call
> >>tzic_enable_wake(1) to set wake source, this will set all enabled
> >>irq as wake source rather than those wake capable. The second
> >>is i.MX5 idle will call mx5_cpu_lp_set() to prepare enter low power
> >>mode, but it forgets to call wfi instruction to enter this mode.
> >>
> >>To fix these two problems, using generic irq chip pm interface and
> >>adding a new function mx5_arch_idle().
> >>
> >>Signed-off-by: Hui Wang <jason77.wang at gmail.com>
> >
> >As shawn already pointed out this conflicts with the imx-cleanup
> >branch. Can you rework this onto it? Shawn has reworked the SoC
> >specific idle stuff, so this is different now.
> >
> >Also, please find a better subject for this patch. 'modify pm and idle'
> >is not enough.
> >
> >Sascha
> >
> Got it, OK.

Please also add 'ARM: ' prefix to the subject for consistency.

-- 
Regards,
Shawn




More information about the linux-arm-kernel mailing list