[PATCH v2] ARM: OMAP3: hwmod: fix variant registration and remove SmartReflex from common list

Tony Lindgren tony at atomide.com
Thu Oct 6 19:29:00 EDT 2011


* Paul Walmsley <paul at pwsan.com> [111006 15:50]:
> 
> Commit d6504acd2125984c61dce24727dd3842d0144015 ("OMAP2+: hwmod:
> remove OMAP_CHIP*") tests the inverse condition of what it should be
> testing for the return value from omap_hwmod_register().  This causes
> several IP blocks to not be registered on several OMAP3 family devices.
> 
> Fixing that bug also unmasked another bug, originally reported by
> Chase Maupin <chase.maupin at ti.com> and then subsequently by Abhilash K
> V <abhilash.kv at ti.com>, which caused SmartReflex IP blocks to be
> registered on SoCs that don't support them.
> 
> Thanks to Russell King - ARM Linux <linux at arm.linux.org.uk> for comments
> on a previous version of the patch.
> 
> Signed-off-by: Paul Walmsley <paul at pwsan.com>
> Cc: Chase Maupin <chase.maupin at ti.com>
> Cc: Abhilash K V <abhilash.kv at ti.com>
> Cc: Russell King - ARM Linux <linux at arm.linux.org.uk>
> ---
> 
> This version incorporates some comments from RMK.

Thanks, updating in fixes-part2.

Tony



More information about the linux-arm-kernel mailing list