[PATCH 0/2] OMAP: Update nr_irqs field in machine descriptors

Tony Lindgren tony at atomide.com
Thu Oct 6 15:50:16 EDT 2011


* S, Venkatraman <svenkatr at ti.com> [110825 07:23]:
> On Thu, Aug 25, 2011 at 5:19 PM, Cousson, Benoit <b-cousson at ti.com> wrote:
> > Hi Venkat,
> >
> > On 8/24/2011 9:46 PM, S, Venkatraman wrote:
> >>
> >> As part of an effort to get single ARM kernel binary [1],
> >> multiple  definitions of NR_IRQS under various platforms
> >> have to be reconciled and abstracted away from common code.
> >>
> >> This patch series takes the small step of populating the
> >> machine descriptors with the pre-existing nr_irqs field.
> >> Eventually, the common irq handler code will only look at this
> >> field and not the compile time constant.
> >
> > Not related to this patch, but still on that topic. The current NR_IRQS
> > depends as well on board stuff, like for example : the Phoenix
> > IRQs:TWL6030_IRQ_BASE, TWL6040_CODEC_IRQ_BASE.
> > Is there a plan to get rid of this static defines?
> >
> 
> Currently, the goal is to get rid of the singleton nature
> of NR_IRQS. Then it just becomes a property of the
> platform, and the arm common code should not see this define.
> This cleanup has to be done across multiple SoCs, not just OMAP.
> 
> After I get to complete some meaningful cleanup of NR_IRQS,
> I can look into the static defines that you mention.

I suggest we wait on this patch as the NR_IRQS should be the
board specific true number of interrupts including chained
interrupts from external devices like twl. So just setting
it to NR_IRQS does not help much. Also, the board-*.c files
will be going aways with device tree at some point.

Regards,

Tony



More information about the linux-arm-kernel mailing list