[PATCH 2/2] hw_random: add driver for atmel true hardware random number generator

Peter Korsgaard jacmet at sunsite.dk
Thu Oct 6 13:53:04 EDT 2011


>>>>> "Jamie" == Jamie Iles <jamie at jamieiles.com> writes:

 Jamie> Hi Peter,
 Jamie> A couple of minor nits inline, but otherwise looks nice to me!

Thanks for the review.

 Jamie> Could you do:

 Jamie> struct atmel_trng {
 Jamie> 	struct clk *clk;
 Jamie> 	void __iomem *base;
 Jamie> 	struct hwrng rng;
 Jamie> };

Sure. Multiple trngs doesn't make much sense, but that approach leads to
slightly less lines, so ok.

I'll send an updated patch shortly.

-- 
Bye, Peter Korsgaard



More information about the linux-arm-kernel mailing list