[PATCH RESEND] ARM: smp_twd: Reconfigure clockevents after cpufreq change

Thomas Gleixner tglx at linutronix.de
Thu Oct 6 13:25:53 EDT 2011


On Thu, 6 Oct 2011, Linus Walleij wrote:

> 2011/9/6 Linus Walleij <linus.walleij at stericsson.com>:
> 
> > From: Colin Cross <ccross at android.com>
> >
> > The localtimer's clock changes with the cpu clock. After a
> > cpufreq transition, update the clockevent's frequency and
> > reprogram the next clock event.
> 
> Thomas do you think you can have a look at this patch and ACK
> it if it looks OK to you? It's the use of clockevents_update_freq()
> function you added after we discussed this in Budapest.
> 
> Since it's likely the first user of that infrastructure we need
> to get it right.

The usage is correct.
 
> Here is the entire patch i Russells tracker:
> http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=6956/2

The only thing what puzzles me is:

> +	if (!IS_ERR_OR_NULL(twd_clk))
> +		twd_timer_rate = clk_get_rate(twd_clk);
> +	else
> +		twd_calibrate_rate();

How is made sure that the cpu freq update thing is not called when
twd_clk is not available or am I missing something ?

Thanks,

	tglx



More information about the linux-arm-kernel mailing list