[PATCH v4 06/10] ARM: SoC: convert Exynos4 to SoC descriptor

Kukjin Kim kgene.kim at samsung.com
Tue Oct 4 21:22:08 EDT 2011


Marc Zyngier wrote:
> 
> On 04/10/11 14:16, Kukjin Kim wrote:
> > Marc Zyngier wrote:
> >>
> >> Convert Exynos4 to use the SoC descriptor to provide its SMP
> >> and CPU hotplug operations.
> >>
> >> Cc: Kukjin Kim <kgene.kim at samsung.com>
> >> Signed-off-by: Marc Zyngier <marc.zyngier at arm.com>
> >> ---
> >>  arch/arm/mach-exynos4/core.h                |    9 +++++++++
> >>  arch/arm/mach-exynos4/cpu.c                 |    8 ++++++++
> >>  arch/arm/mach-exynos4/hotplug.c             |    8 +++++---
> >>  arch/arm/mach-exynos4/mach-armlex4210.c     |    3 +++
> >>  arch/arm/mach-exynos4/mach-nuri.c           |    3 +++
> >>  arch/arm/mach-exynos4/mach-origen.c         |    3 +++
> >>  arch/arm/mach-exynos4/mach-smdk4212.c       |    3 +++
> >>  arch/arm/mach-exynos4/mach-smdkv310.c       |    4 ++++
> >>  arch/arm/mach-exynos4/mach-universal_c210.c |    3 +++
> >>  arch/arm/mach-exynos4/platsmp.c             |   25
> >> +++++++++++++++++++++----
> >>  10 files changed, 62 insertions(+), 7 deletions(-)
> >>  create mode 100644 arch/arm/mach-exynos4/core.h
> >>
> >> diff --git a/arch/arm/mach-exynos4/core.h
b/arch/arm/mach-exynos4/core.h
> >> new file mode 100644
> >> index 0000000..ba9fcc8
> >> --- /dev/null
> >> +++ b/arch/arm/mach-exynos4/core.h
> >
> > Is there any reason to add core.h in mach-exynos4 not
> > mach-exynos4/include/mach?
> 
> No particular reason. If you prefer having that file in include/mach,
> I'll move it, though I don't think it makes much more sense.
> 
I was just wondering, and I'd like to keep same format with other platforms.

> >> +
> >> +struct arm_soc_desc exynos4_soc_desc __initdata = {
> >> +	.name		= "Samsung Exynos4",
> >
> > If you're ok, I preferred 'Samsung EXYNOS4'
> 
> No problem.
> 
Thanks.

> > And could you please re-work this based on latest my for-next because
there
> > are updated board file.
> 
> Where is your for-next branch located these days? When it gets picked up
> by linux-next, I'll update the board files. As of next-20111004, I seem
> to cover them all.
> 
Now it is 'git://github.com/kgene/linux-samsung.git' and it will be moved
'git.kernel.org' soon. And as you said since linux-next is maybe having all
-next trees, if you pick it up it is ok to me too :)

If this series get the acks from regarding maintainers, is it possible to
send this EXYNOS stuff via Samsung tree to avoid conflicts? And you know it
can be tested with others by linux-next even though separate merging.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim at samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.




More information about the linux-arm-kernel mailing list