[PATCH 1/4] ARM: OMAP3 PM: Fix IO Daisychain sequence
Tony Lindgren
tony at atomide.com
Tue Oct 4 14:54:15 EDT 2011
* Vishwanath BS <vishwanath.bs at ti.com> [111004 10:25]:
> @@ -105,7 +105,7 @@ static void omap3_enable_io_chain(void)
> /* Do a readback to assure write has been done */
> omap2_prm_read_mod_reg(WKUP_MOD, PM_WKEN);
>
> - while (!(omap2_prm_read_mod_reg(WKUP_MOD, PM_WKEN) &
> + while (!(omap2_prm_read_mod_reg(WKUP_MOD, PM_WKST) &
> OMAP3430_ST_IO_CHAIN_MASK)) {
> timeout++;
> if (timeout > 1000) {
Checking for PM_WKST here makes sense..
> @@ -114,7 +114,7 @@ static void omap3_enable_io_chain(void)
> return;
> }
> omap2_prm_set_mod_reg_bits(OMAP3430_ST_IO_CHAIN_MASK,
> - WKUP_MOD, PM_WKEN);
> + WKUP_MOD, PM_WKST);
> }
> }
> }
..but are you sure you also want to write into PM_WKST?
Tony
More information about the linux-arm-kernel
mailing list