[PATCH] ARM: remove bashism in check for multiple zreladdrs

Sascha Hauer s.hauer at pengutronix.de
Tue Oct 4 03:34:04 EDT 2011


On Mon, Oct 03, 2011 at 10:22:16PM +0530, Rabin Vincent wrote:
> Get rid of this complaint from dash:
> 
>     AS      arch/arm/boot/compressed/lib1funcs.o
>   /bin/sh: 1: [: y: unexpected operator
>     LD      arch/arm/boot/compressed/vmlinux
> 
> Cc: Sascha Hauer <s.hauer at pengutronix.de>
> Signed-off-by: Rabin Vincent <rabin at rab.in>

Acked-by: Sascha Hauer <s.hauer at pengutronix.de>

I guess using '=' for a comparison is hard to type for a C programmer ;)

Sascha

> ---
>  arch/arm/boot/compressed/Makefile |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/boot/compressed/Makefile b/arch/arm/boot/compressed/Makefile
> index a53a333..a6b30b3 100644
> --- a/arch/arm/boot/compressed/Makefile
> +++ b/arch/arm/boot/compressed/Makefile
> @@ -140,7 +140,7 @@ bad_syms=$$($(CROSS_COMPILE)nm $@ | sed -n 's/^.\{8\} [bc] \(.*\)/\1/p') && \
>      echo "$$bad_syms" >&2; rm -f $@; false )
>  
>  check_for_multiple_zreladdr = \
> -if [ $(words $(ZRELADDR)) -gt 1 -a "$(CONFIG_AUTO_ZRELADDR)" == "" ]; then \
> +if [ $(words $(ZRELADDR)) -gt 1 -a "$(CONFIG_AUTO_ZRELADDR)" = "" ]; then \
>  	echo 'multiple zreladdrs: $(ZRELADDR)'; \
>  	echo 'This needs CONFIG_AUTO_ZRELADDR to be set'; \
>  	false; \
> -- 
> 1.7.5.4
> 
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



More information about the linux-arm-kernel mailing list