[PATCH] ARM: localtimer: add header linux/errno.h explicitly

Russell King - ARM Linux linux at arm.linux.org.uk
Sat Oct 1 12:37:21 EDT 2011


On Fri, Sep 30, 2011 at 10:02:10AM +0800, Shawn Guo wrote:
> Hi Russell,
> 
> Do you have any comment on this patch?  Otherwise, I will put it into
> patch tracker.

Only that the include should be towards the top of the file rather
than conditionally included.  That avoids potential surprise compile
errors caused by changes in configuration.  (Ok, you may argue that
they shouldn't happen but with the amount of includes we have it's
very difficult to ensure that everything explicitly includes everything
it actually needs.)



More information about the linux-arm-kernel mailing list