[PATCH v4 3/7] arm/imx: add gic_handle_irq function

Russell King - ARM Linux linux at arm.linux.org.uk
Sat Oct 1 11:13:00 EDT 2011


On Thu, Sep 29, 2011 at 10:08:05PM +0800, Shawn Guo wrote:
> Can you please share your position on Marc's PPI and GIC
> MULTI_IRQ_HANDLER series?  Are you possibly going to merge them in the
> coming merge window?  If you are, I would directly move my imx6q onto
> those series and save the local gic_handle_irq().  Otherwise, I may
> have to add a wrapper for do_IPI() and do_local_timer() to work around
> the pt_regs issue you pointed out here.

My personal opinion of Marc's PPI patches hasn't changed: I think
integrating them into genirq just makes the whole thing a lot more
complicated (and error-prone) than it otherwise needs to be.

For example, it is completely invalid to call any of the existing
genirq APIs for a PPI interrupt, because there is no sane way to ensure
that the intended CPU is targetted - unless we're operating from a thread
which is bound specifically to a single CPU.

However, Marc has been working with Thomas to produce something more
generic (and not ARM specific) and I don't have an opinion on that.
This addresses the issues (like the one I mention above) but I've not
been following it any further than that.



More information about the linux-arm-kernel mailing list