[PATCH 1/3] ARM: AT91: Add platform data for the ADCs
Linus Walleij
linus.ml.walleij at gmail.com
Thu Nov 3 07:27:28 EDT 2011
2011/11/3 Maxime Ripard <maxime.ripard at free-electrons.com>:
> Cc: Nicolas Ferre <nicolas.ferre at atmel.com>
> Cc: Patrice Vilchez <patrice.vilchez at atmel.com>
> Signed-off-by: Maxime Ripard <maxime.ripard at free-electrons.com>
> ---
> arch/arm/mach-at91/include/mach/board.h | 22 ++++++++++++++++++++++
> 1 files changed, 22 insertions(+), 0 deletions(-)
We're not supposed to have platform data dependent to stuff in
staging under arch/arm or anyplace else in the main kernel tree.
Please move this to
drivers/staging/iio/adc/at91adc-board.h
or so.
As for calling the at91_add_device_adc() function (which I guess
you want to do at some point) the pattern I followed for other
drivers is to declare a dummy function in arch/arm/mach-*
with __weak and let the staging driver override that. This way
the staging driver can go away without any compilation trouble
happening.
Yours,
Linus Walleij
More information about the linux-arm-kernel
mailing list