[PATCH 13/15] OMAP: GPIO: cleanup _set_gpio_wakeup(), remove ifdefs

[Kevin Hilman]

"Varadarajan, Charulatha" <charu at ti.com> writes:

> On Sat, Apr 23, 2011 at 04:32, Kevin Hilman <khilman at ti.com> wrote:
>> Make _set_gpio_wakeup() generic by removing ifdefs.  Code for the
>> various SoCs/bank-methods was already the same, except for the
>> non-wakeup GPIO checking.  But that flag is set on a per-SoC basis, so
>> can be used for all SoCs.
>>
>> While here, use pr_err() and remove GPIO bank calculation assumption
>> based on subtracting bank pointers.
>>
>> Signed-off-by: Kevin Hilman <khilman at ti.com>

[...]

>> -#endif
>> -       default:
>> -               printk(KERN_ERR "Can't enable GPIO wakeup for method %i\n",
>> -                      bank->method);
>> +       if (bank->non_wakeup_gpios & gpio_bit) {
>> +               pr_err("Unable to modify wakeup on non-wakeup GPIO%d\n", gpio);
>
> use dev_err instead.

Agreed, thanks.

Kevin