[PATCH v17 08/13] davinci: eliminate use of IO_ADDRESS() on sysmod
Nori, Sekhar
nsekhar at ti.com
Wed Mar 23 02:39:34 EDT 2011
On Tue, Mar 22, 2011 at 18:45:03, Arnd Bergmann wrote:
> On Tuesday 22 March 2011, Nori, Sekhar wrote:
> > .. but forgot to fix this. There is nothing wrong with
> > using writel, but it doesn't fit into what the subject
> > of this patch is.
>
> Well, to be more exact, the __raw_writel was actually
> wrong here and it should be writel(), but it's certainly
> better to mention the reason in the changelog, or to
> make a separate patch for it.
I wouldn't necessarily classify the use of __raw_writel as wrong
(as in a bug) - since the specific code is question is only run
on ARMv5 based SoCs.
A lot of DaVinci code uses __raw_* variants, and perhaps should
be changed to use readl/writel instead - at least it will help
copying that code over for other uses.
That should be the subject of separate (series of) patches.
Thanks,
Sekhar
More information about the linux-arm-kernel
mailing list