[PATCH] Input: tca6416-keypad: Change to module_init()

[Mark Brown]

On Wed, Mar 23, 2011 at 01:20:23AM +0900, Magnus Damm wrote:
> On Wed, Mar 23, 2011 at 12:57 AM, Paul Mundt <lethal at linux-sh.org> wrote:

> > In this case I would suspect general indifference or simply copying other
> > drivers. I2C is a bit of a tricky case with regards to ordering in
> > general, but at least input devices are relatively straightforward.

> I remember having to move the init order around at least once before
> in the case of i2c, so I'm not so surprised when new initcall issues
> come up now and then.

It's mostly an issue for PMICs (and possibly some other similar things)
so that the regulators are present before their consumers try to start.
I'm not aware of any issues with I2C itself.

> The "may" above comes from that I don't know the i2c bus driver
> initcall time on non-SH-Mobile platforms. So this may trigger on other
> platforms, or it may not depending on their cpu/board code and I2c bus
> driver.

In general embedded platforms register I2C early as things like PMICs
typically hang off them.  Grant was trying to push people to use
deferred registration for this stuff but it didn't happen yet and I'd
personally be more comfortable with more infastructure supporting that.