[PATCH 1/2] drivers/watchdog/s3c2410_wdt.c: Convert release_resource to release_region/release_mem_region
Wim Van Sebroeck
wim at iguana.be
Fri Mar 18 05:12:50 EDT 2011
Hi Julia,
> Actually, I later realized that one can also use the result of
> request_mem_region in place of res. Even though it is not the same
> structure, it has the same start and end field information, which is the
> only information that is used. But I haven't had a chance to send a patch
> that follows that strategy. So if it is preferred to keep res, then that
> can be done.
If you look at the driver then you will see that it will use wdt_base to control the device:
static void __iomem *wdt_base;
...
res=platform_get_resource(pdev, IORESOURCE_MEM, 0);
...
wdt_base = ioremap(res->start, size);
So the memory resource is only used for:
1) requesting the memory region
2) ioremapping the memory so that we can use the registers.
My opinion: res can go out so that wdt_mem and wdt_irq get similar platform resource info.
Kind regards,
Wim.
More information about the linux-arm-kernel
mailing list