[PATCH 2/9] lpc2k: Exception vector handling

[Greg Ungerer]

On 18/03/11 02:28, Ithamar R. Adema wrote:
> On Thu, 2011-03-17 at 17:18 +0100, Uwe Kleine-K÷nig wrote:
>> On Thu, Mar 17, 2011 at 04:54:17PM +0100, Ithamar R. Adema wrote:
>>> diff --git a/arch/arm/kernel/entry-armv.S b/arch/arm/kernel/entry-armv.S
>>> index e8d8856..618a971 100644
>>> --- a/arch/arm/kernel/entry-armv.S
>>> +++ b/arch/arm/kernel/entry-armv.S
>>> @@ -1208,6 +1208,7 @@ __stubs_end:
>>>
>>>   	.globl	__vectors_start
>>>   __vectors_start:
>>> +#ifndef CONFIG_ARCH_LPC2K
>>>    ARM(	swi	SYS_ERROR0	)
>>>    THUMB(	svc	#0		)
>>>    THUMB(	nop			)
>>> @@ -1218,6 +1219,23 @@ __vectors_start:
>>>   	W(b)	vector_addrexcptn + stubs_offset
>>>   	W(b)	vector_irq + stubs_offset
>>>   	W(b)	vector_fiq + stubs_offset
>>> +#else /* CONFIG_ARCH_LPC2K */
>> The description from the commit log should be repeated here.
>
> OK, will include the description as comment there in the next version.
>
>> And I wonder if this shouldn't depend on CONFIG_ARCH_LPC2K but
>> CONFIG_MMU.
>
> Well, looking at th uClinux kernel tree, it seems this was only done for
> the NXP LPC2K range, so that's why I kept it under CONFIG_ARCH_LPC2K.

IIRC most of the non-MMU ARMs had the vectors in normal RAM, so they
would end up close to the code. That is why this may have been the
only one with the vectors ending up a long way away. So it is not
specific to non-MMU, but one day there may be other types that need
to do this too.

Regards
Greg


>>> +	swi	SYS_ERROR0
>> I think arm7tdmi doesn't have thumb2, does it? If it has you need to do
>> ARM(swi SYS_ERROR0)
>> THUMB(svc ..)
>> ...
>>
>> as above
>
> Correct, the ARM7TDMI-S only supports Thumb, not Thumb2.
>
> Thanks for reviewing!
>
> Ithamar.
>
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
>
>


-- 
------------------------------------------------------------------------
Greg Ungerer  --  Principal Engineer        EMAIL:     gerg at snapgear.com
SnapGear Group, McAfee                      PHONE:       +61 7 3435 2888
8 Gardner Close                             FAX:         +61 7 3217 5323
Milton, QLD, 4064, Australia                WEB: http://www.SnapGear.com