[PATCH 1/2] [ARM] am200epd: fix resource leak in am200_init_gpio_regs error path
Eric Miao
eric.y.miao at gmail.com
Thu Mar 17 11:07:02 EDT 2011
Applied.
On Mon, Mar 7, 2011 at 1:55 PM, Axel Lin <axel.lin at gmail.com> wrote:
> If gpio_request fails when i > 0, gpios[0] is not freed in current
> implementation.
>
> Signed-off-by: Axel Lin <axel.lin at gmail.com>
> ---
> arch/arm/mach-pxa/am200epd.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-pxa/am200epd.c b/arch/arm/mach-pxa/am200epd.c
> index 3499fad..811d797 100644
> --- a/arch/arm/mach-pxa/am200epd.c
> +++ b/arch/arm/mach-pxa/am200epd.c
> @@ -128,8 +128,8 @@ static int am200_init_gpio_regs(struct metronomefb_par *par)
> return 0;
>
> err_req_gpio:
> - while (i > 0)
> - gpio_free(gpios[i--]);
> + while (--i >= 0)
> + gpio_free(gpios[i]);
>
> return err;
> }
> --
> 1.7.2
>
>
>
>
More information about the linux-arm-kernel
mailing list