Why don't we have atomic_set_mask()?

Russell King - ARM Linux linux at arm.linux.org.uk
Thu Mar 17 08:07:48 EDT 2011


On Thu, Mar 17, 2011 at 08:36:15PM +0900, KyongHo Cho wrote:
> arch/arm/asm/atomic.h defines atomic_clear_mask() but its counterpart,
> atomic_set_mask() is not defined.

Nothing other than some s390 drivers seems to use it, so I'd say no.
I also feel that atomic_xxx() is over-used, many times in inappropriate
and buggy ways.

If you want to manipulate bitmasks or bitmaps, then imho you should be
using the bitops or bitmap support rather than atomic stuff.



More information about the linux-arm-kernel mailing list