[PATCHv2 1/9] at91: provide macb clks with "pclk" and "hclk" name
Andrew Victor
avictor.za at gmail.com
Thu Mar 17 05:22:37 EDT 2011
hi Russell,
>> There is no reference to a "pclk" or "hclk" in the AT91 architecture.
>> So to avoid possible confusion, maybe create two "fake" clocks both
>> parented to "macb_clk", and add a comment they're only for
>> compatibility with the AVR32.
>
> It doesn't matter what's in the documentation.
>
> What matters more than conforming to documentation is keeping the drivers
> in a clean and maintainable state without throwing lots of ifdefs into
> them.
I'm not saying the drivers need ifdefs, they should request both
"pclk" and "hclk" as suggested.
What I was suggesting is the platform clock setup on AT91 as:
macb_clk
|
+-- hclk
+-- pclk
rather than:
pclk
|
+-- hclk
Regards,
Andrew Victor
More information about the linux-arm-kernel
mailing list