[PATCHv2 3/9] macb: unify at91 and avr32 platform data

Peter Korsgaard jacmet at sunsite.dk
Thu Mar 17 04:48:28 EDT 2011


>>>>> "avictor" == avictor za at gmail com <avictor.za at gmail.com> writes:

Hi,

 >> How about at the same time renaming it to something a bit less
 >> generic like macb_platform_data?

 avictor> The AT91RM9200 uses the same platform_data structure, but has a
 avictor> different Ethernet peripheral (ie, not the MACB)

 avictor> The phy_irq_pin is used in the AT91RM9200 ethernet driver.
 avictor> (drivers/net/arm/at91_ether.c)

That should probably be cleaned up as well then. Sharing platform_data
structures between unrelated drivers seems like quite a mess to me.

-- 
Bye, Peter Korsgaard



More information about the linux-arm-kernel mailing list