[PATCH] ARM: S3C64XX: Fix section mismatch from cpufreq init

Mark Brown broonie at opensource.wolfsonmicro.com
Wed Mar 16 06:53:47 EDT 2011


On Wed, Mar 16, 2011 at 11:13:00AM +0100, Uwe Kleine-König wrote:
> On Wed, Mar 16, 2011 at 09:49:59AM +0000, Mark Brown wrote:

> > That's what I said above, pretty much.  Ideally we'd have a way of
> > annotating the call sites so that the linker infrastructure rather than
> > having to faff about splitting the structures like this.

> You can mark the driver struct using __ref. But IMHO not saving a
> reference to a function only used once is cleaner.

It's pretty annoying to have to define two structs for the affected
drivers (it's not like cpufreq is the only affected subsystem here) -
there's good reasons why we use things like __devexit_p() rather than
split structs for common cases like this.



More information about the linux-arm-kernel mailing list