[PATCH 5/8] ARM: PXA: Z2: Add poweroff function

Eric Miao eric.y.miao at gmail.com
Tue Mar 15 11:49:26 EDT 2011


2011/3/13 Marek Vasut <marek.vasut at gmail.com>:
> On Saturday 12 March 2011 21:34:01 Vasily Khoruzhick wrote:
>> On Saturday 12 March 2011 15:16:19 Marek Vasut wrote:
>> > Besides, this is nonsense, you're doing a hack and you're trying to
>> > justify it. You cannot powerdown the device, period. You should rather
>> > patch the bootloader to implement this para-powerdown behaviour than
>> > bloat kernel with this workaround.
>>
>> And, btw, there's same code in mainline kernel for zeus machine.
>
> Doesn't mean it's correct. CCing maintainer. Eric, can you also please comment
> on it ? I really don't like the idea of abusing poweroff and making people
> misunderstand.

I'm actually quite OK with the idea of using deep sleep as a way
for shutdown. As some of the device has no way for a "correct"
shutdown without pulling out the battery. A fake one is at least
better than none, provided it works as expected.

>
> Cheers
>



More information about the linux-arm-kernel mailing list