[PATCHv2 3/9] macb: unify at91 and avr32 platform data
Jean-Christophe PLAGNIOL-VILLARD
plagnioj at jcrosoft.com
Tue Mar 15 08:36:16 EDT 2011
On 12:14 Tue 15 Mar , Peter Korsgaard wrote:
> >>>>> "Jamie" == Jamie Iles <jamie at jamieiles.com> writes:
>
> Hi,
>
> Jamie> Both at91 and avr32 defines its own platform data structure for
> Jamie> the macb driver and both share common structures though at91
> Jamie> includes a currently unused phy_irq_pin. Create a common
> Jamie> eth_platform_data for macb that both at91 and avr32 can use. In
> Jamie> future we can use this to support other architectures that use the
> Jamie> same IP block with the macb driver.
>
> Nice!
>
> Jamie> Signed-off-by: Jamie Iles <jamie at jamieiles.com>
>
> Jamie> +++ b/include/linux/platform_data/macb.h
> Jamie> @@ -0,0 +1,17 @@
> Jamie> +/*
> Jamie> + * Copyright (C) 2004-2006 Atmel Corporation
> Jamie> + *
> Jamie> + * This program is free software; you can redistribute it and/or modify
> Jamie> + * it under the terms of the GNU General Public License version 2 as
> Jamie> + * published by the Free Software Foundation.
> Jamie> + */
> Jamie> +#ifndef __MACB_PDATA_H__
> Jamie> +#define __MACB_PDATA_H__
> Jamie> +
> Jamie> +struct eth_platform_data {
>
> How about at the same time renaming it to something a bit less generic
> like macb_platform_data?
agreed
Best Regards,
J.
>
> --
> Bye, Peter Korsgaard
More information about the linux-arm-kernel
mailing list