[PATCH 2/2] ARM: mx5/mx53_evk: Remove unneeded gpio_set_value call
Uwe Kleine-König
u.kleine-koenig at pengutronix.de
Tue Mar 15 05:49:46 EDT 2011
On Tue, Mar 15, 2011 at 10:41:37AM +0100, Julia Lawall wrote:
> I tried the following
>
> @@
> expression E1,E2;
> @@
>
> gpio_direction_output(E1,E2);
> ...
> - gpio_set_value(E1,E2);
>
> and found occurrences in 15 files. In some cases there seems to be some
> delay before the call to gpio_set_value. Does that have any impacton
> whether it is needed?
gpio_direction_output(E1,E2) implies gpio_set_value(E1,E2), so unless
there is a gpio_set_value(E1,!E2) before gpio_set_value(E1,E2) is a
noop.
I still don't know how to work with coccinelle, so if you point me to a
concrete location I can be more specific.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
More information about the linux-arm-kernel
mailing list