[PATCH 06/10] ux500: added snowball-netev with latest fixes

Alessandro Rubini rubini-list at gnudd.com
Mon Mar 14 05:04:44 EDT 2011


Hello Arnd.

>> +       volatile u32 *ptr = ioremap(0x80000000, 0x10000);
> 
> I suppose you mean "u32 __iomem *" here, not "volatile u32 *ptr".

Yes, full ack. And also for the rest (as you note, the comment
says "horribly").

Actually, this patch was a quick fix to make things work and proceed
with the board. While other people were working on other devices, I
preferred to (temporarily) have a self-contained hack.

Then I forgot to make it clear to Mathieu that this was not, in my
opinion, ready to get submitted.  Please wait for us to sort this out;
currently I think the patch set should be parked.

> Better use platform_device_register_simple() instead of
> the static device.

Thanks, I didn't know about this.




More information about the linux-arm-kernel mailing list