[PATCH 1/7] ARM: irq: introduce entry and exit functions for chained handlers
Thomas Gleixner
tglx at linutronix.de
Fri Mar 11 14:19:03 EST 2011
On Fri, 11 Mar 2011, Will Deacon wrote:
> > On Tue, 8 Mar 2011, Will Deacon wrote:
> >
> > > Some chained IRQ handlers are written to cope with primary chips of
> > > potentially different flow types. Whether this a sensible thing to do
> > > is a point of contention.
> >
> > That wants a comment that these functions are only dealing with
> > fasteoi and level type flow control.
> >
> > Otherwise fine with me. Feel free to add my Acked-by.
>
> Thanks Thomas, reworded as followed:
>
> ARM: irq: introduce entry and exit functions for chained handlers
>
> Some chained IRQ handlers are written to cope with primary chips of
> potentially different flow types. Whether this a sensible thing to do
> is a point of contention.
>
> This patch introduces entry/exit functions for chained handlers which
> infer the flow type of the primary chip as fasteoi or level-type by
> checking whether or not the ->irq_eoi function pointer is present and
> calling back to the primary chip as necessary. Other methods of flow
> control are not considered.
>
> I'll add your Ack and put this (patch 1) in Russell's patch system next
> week.
Having it in the changelog is nice, but the code itself would like a
comment as well.
Thanks,
tglx
More information about the linux-arm-kernel
mailing list