[PATCH 4/8] macb: initial support for Cadence GEM
Jean-Christophe PLAGNIOL-VILLARD
plagnioj at jcrosoft.com
Fri Mar 11 08:34:45 EST 2011
On 13:30 Fri 11 Mar , Jamie Iles wrote:
> On Fri, Mar 11, 2011 at 02:14:15PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > On 10:10 Thu 10 Mar , Jamie Iles wrote:
> > > The Cadence GEM is based on the MACB Ethernet controller but has a few
> > > small changes with regards to register and bitfield placement. This
> > > patch adds a new platform driver for gem which sets allows the driver to
> > > tell at runtime whether it is targetting a GEM device.
> > >
> > > Signed-off-by: Jamie Iles <jamie at jamieiles.com>
> > could we avoid all this if else everywhere?
>
> I can't really see any other way to do this, but you're right it isn't
> particularly nice. Having said that, it is only in the initialization
> code so there shouldn't be any real performance impact.
>
> I'm open to ideas though!
use macro or inline at least
Best Regards,
J.
More information about the linux-arm-kernel
mailing list