[PATCH] z2-battery: Fix count of properties

Sergei Shtylyov sshtylyov at mvista.com
Fri Mar 11 07:11:45 EST 2011


Hello.

On 11-03-2011 13:03, Vasily Khoruzhick wrote:

> PROP_STATUS property was not counted, as result
> VOLTAGE_MIN property is missing in sysfs. Fix it.

> Signed-off-by: Vasily Khoruzhick<anarsoul at gmail.com>
> ---
>   drivers/power/z2_battery.c |    2 ++
>   1 files changed, 2 insertions(+), 0 deletions(-)

> diff --git a/drivers/power/z2_battery.c b/drivers/power/z2_battery.c
> index e5ed52d..551d7bf 100644
> --- a/drivers/power/z2_battery.c
> +++ b/drivers/power/z2_battery.c
> @@ -134,6 +134,8 @@ static int z2_batt_ps_init(struct z2_charger *charger, int props)
>   	enum power_supply_property *prop;
>   	struct z2_battery_info *info = charger->info;
>
> +	if (info->charge_gpio>= 0)
> +		props++; /* POWER_SUPPLY_PROP_STATUS */

    Why not align this comment with the below one?

>   	if (info->batt_tech>= 0)
>   		props++;	/* POWER_SUPPLY_PROP_TECHNOLOGY */
>   	if (info->batt_I2C_reg>= 0)

WBR, Sergei



More information about the linux-arm-kernel mailing list