[PATCH V6 02/17] ST SPEAr13xx: Added PCIe host controller base driver support.

shiraz hashim shiraz.linux.kernel at gmail.com
Thu Mar 10 07:45:13 EST 2011


Hello Arnd,

On Tue, Mar 1, 2011 at 8:40 PM, Arnd Bergmann <arnd at arndb.de> wrote:
> On Tuesday 01 March 2011, Viresh Kumar wrote:
>> From: Pratyush Anand <pratyush.anand at st.com>

[...]

>> diff --git a/arch/arm/mach-spear13xx/include/mach/hardware.h b/arch/arm/mach-spear13xx/include/mach/hardware.h
>> index fd8c2dc..c3fb454 100644
>> --- a/arch/arm/mach-spear13xx/include/mach/hardware.h
>> +++ b/arch/arm/mach-spear13xx/include/mach/hardware.h
>> @@ -28,4 +28,11 @@
>>  /* typesafe io address */
>>  #define __io_address(n)              __io(IO_ADDRESS(n))
>
> I could not find the definition for __io() here, but I suspect this is
> wrong. If __io_address() is what you use for accessing the direct-mapped
> MMIO registers, it cannot also be what you use to access the PCIe PIO
> ports, so most likely one of the two is broken. Can you explain?

This is not used in PCIe and infact is not part of this PCIe patch.
This is used at few places in the architecture code.

-- 
regards
Shiraz Hashim



More information about the linux-arm-kernel mailing list