[PATCH 1/3] video: mxsfb: smarten the code a little bit

Shawn Guo shawn.guo at freescale.com
Sat Mar 5 23:09:21 EST 2011


Hi Arnd,

On Sat, Mar 05, 2011 at 05:41:11PM +0100, Arnd Bergmann wrote:
> On Saturday 05 March 2011 17:18:49 Shawn Guo wrote:
> > @@ -882,7 +884,6 @@ static struct platform_device_id mxsfb_devtype[] = {
> >         }, {
> >                 .name = "imx28-fb",
> >                 .driver_data = MXSFB_V4,
> > -       }, {
> >         },
> >  };
> 
> This is broken, you need to have an empty entry as the end marker,
> otherwise, the match function will interpret whatever comes in 
> memory after the last entry as input data, until it hits zeroes.
> 
Ah, my dumb.  Thanks for pointing this out.  I will recover it with
a marker, and also prepare a patch to fix the exactly same issue I
created in fec.c :)

-- 
Regards,
Shawn




More information about the linux-arm-kernel mailing list