[PATCH] ARM: S5PC210: add support for i2c PMICs on Universal_C210 board
Russell King - ARM Linux
linux at arm.linux.org.uk
Sat Mar 5 06:21:38 EST 2011
On Thu, Mar 03, 2011 at 11:40:26AM +0900, Kyungmin Park wrote:
> On Tue, Feb 15, 2011 at 8:35 PM, Russell King - ARM Linux
> <linux at arm.linux.org.uk> wrote:
> > On Tue, Feb 15, 2011 at 11:59:15AM +0100, Marek Szyprowski wrote:
> >> #include <mach/map.h>
> >> +#include <mach/gpio.h>
> > Need I say anything about this?
> Hi Russell,
> How about to prevent it as compiler error? It's frequent mistake.
> At each mach/gpio.h
> #ifndef __LINUX_GPIO_H
> #error "You should include <linux/gpio.h> instead of <mach/gpio.h>."
It doesn't stop people including linux/gpio.h and then mach/gpio.h,
which is also a common mistake. Besides, it's easy to catch when you
have a regexp setup in your mail reader to find them...
More information about the linux-arm-kernel