[PATCH 0/4] OMAP 3 and 4 i2c fixes

Cousson, Benoit b-cousson at ti.com
Thu Mar 3 16:55:54 EST 2011

To summarize my comments on your series.

On 3/3/2011 2:50 PM, Andy Green wrote:
> The following series fixes two issues with OMAP 3 and 4 i2c support.
> First, hwmod tables don't have the i2c units marked up as being
> for 16-bit access only, which is mandatory.

That part is OK, and should just be extended to 2430 for the sake of 
completeness. A rev attribute should be added as well for the second part.

> Second, the i2c peripheral unit init code is confused about using
> cpu_is...() and probed peripheral unit version, leading to OMAP3
> i2c code doing the wrong thing and accessing nonexistant registers.

That part should be revisited to use a better way to identify the IP 

Most of the code is there, you just have to copy the correct information 
during I2C device init.

Just let me know if you are not comfortable with that latest part, some 
l-o folks, including me, can help you.


More information about the linux-arm-kernel mailing list