[PATCH] ARM: mx51: Print silicon revision on boot

[Arnaud Patard (Rtp)]

Sascha Hauer <s.hauer at pengutronix.de> writes:

Hi,

> On Thu, Mar 03, 2011 at 12:43:14PM -0300, Fabio Estevam wrote:
>> Hi Arnaud,
>> 
>> On Thu, Mar 3, 2011 at 5:24 AM, Arnaud Patard <arnaud.patard at rtp-net.org> wrote:
>> > Fabio Estevam <festevam at gmail.com> writes:
>> > Hi,
>> >
>> >> Signed-off-by: Fabio Estevam <fabio.estevam at freescale.com>
>> >
>> > Why I like having boot log, I don't like have too verbose boot logs. If
>> > you add this, you have a good reason (I hope), but I can't know
>> > it. There's no patch description. So, please give a patch with proper
>> > explanation of why you need that. Anyway, having a proper patch
>> > description is imho always a good idea.
>> 
>> I think that printing the silicon version on boot is useful
>> information. Many issues are fixed in the latest silicon revision, so
>> while debugging mx51 issues it is good to know from the boot log if
>> someone is using the latest silicon version or not.
>
> +1
>
> There is less useful information in the bootlog than this. Also, there's
> the quiet option to not wait on the slow serial console.

You missed something in my mail. My point was not really about log
verbosity. There was *no* description at all. We both know that silicon
rev 2.0 has some nasty bugs like broken neon which has been fixed in rev
3.0 so it may be a good idea to print that but without proper
description, the aim may well have been "I want to print this because I
find it nice". I know it may be hard to write proper description but
here, it's not. I even got a good description as answer to my mail. I
should not had to ask for it.

Arnaud