[PATCH 11/17] omap4: suspend: Add MPUSS RET and OFF support

Santosh Shilimkar santosh.shilimkar at ti.com
Thu Mar 3 11:31:51 EST 2011


> -----Original Message-----
> From: Kevin Hilman [mailto:khilman at ti.com]
> Sent: Thursday, March 03, 2011 4:16 AM
> To: Santosh Shilimkar
> Cc: linux-omap at vger.kernel.org; linux-arm-kernel at lists.infradead.org
> Subject: Re: [PATCH 11/17] omap4: suspend: Add MPUSS RET and OFF
> support
>
> Santosh Shilimkar <santosh.shilimkar at ti.com> writes:
>

[...]
> > +
> > +	/* Set targeted power domain states by suspend */
> > +	list_for_each_entry(pwrst, &pwrst_list, node) {
> > +		/* FIXME: Remove this check when CORE retention is
> supported */
> > +		if (!strcmp(pwrst->pwrdm->name, "mpu_pwrdm"))
> > +			omap_set_pwrdm_state(pwrst->pwrdm, pwrst-
> >next_state);
> > +	}
>
> pwrst_list is the list of powerdomains to that will be changed
> during suspend.
>
> Rather than doing this string match for every suspend, just do the
> check once during init and only add powerdomains that can
> transition to the list.
>
Will fix this accordingly then.



More information about the linux-arm-kernel mailing list