[PATCH] ARM: mx51: Print silicon revision on boot

[Fabio Estevam]

Hi Arnaud,

On Thu, Mar 3, 2011 at 5:24 AM, Arnaud Patard <arnaud.patard at rtp-net.org> wrote:
> Fabio Estevam <festevam at gmail.com> writes:
> Hi,
>
>> Signed-off-by: Fabio Estevam <fabio.estevam at freescale.com>
>
> Why I like having boot log, I don't like have too verbose boot logs. If
> you add this, you have a good reason (I hope), but I can't know
> it. There's no patch description. So, please give a patch with proper
> explanation of why you need that. Anyway, having a proper patch
> description is imho always a good idea.

I think that printing the silicon version on boot is useful
information. Many issues are fixed in the latest silicon revision, so
while debugging mx51 issues it is good to know from the boot log if
someone is using the latest silicon version or not.

We currently do that on mx31/mx35 kernel, and I think it would be nice
to have this information for mx5 as well.

It is just a single line, so don´t believe it will add any significant overhead.

> Moreover, there's already good hint if you want to know if you're on to2
> or to3. On rev < 3.0, you have this in logs:
> VFP support v0.3: implementor 41 architecture 3 part 30 variant c rev 2
> Turning off NEON support, detected broken NEON implementation

Ok, but still I prefer one single line stating the CPU version explicitly.

Regards,

Fabio Estevam