[PATCHv1] ARM: imx: Add support for low power suspend on MX51.

Russell King - ARM Linux linux at arm.linux.org.uk
Thu Mar 3 06:52:42 EST 2011


On Wed, Mar 02, 2011 at 10:52:38PM +0100, Uwe Kleine-König wrote:
> > +static int __init mx5_pm_init(void)
> > +{
> > +	if (cpu_is_mx51())
> > +		suspend_set_ops(&mx5_suspend_ops);
> I'd prefer to have that called by imx51_init_early.

This function name looks fine.  As we now have an init_early in the
arch hooks, let's keep things called foo_init_early() to that use
and not start using 'early' for stuff used from initcalls.

Renaming this is a recipe for causing confusion and having grep hit
false positives.  Please leave it as is.



More information about the linux-arm-kernel mailing list