[PATCH v2 10/18] omap3+: sr: call handler with interrupt disabled

Sergei Shtylyov sshtylyov at mvista.com
Wed Mar 2 12:39:02 EST 2011


I wrote:

>> Request the handler irq such that there is no nesting for calls.
>> the notifiers are not expected to be nested, further the interrupt
>> events for status change should be handled prior to the next event
>> else there is a risk of loosing events.

>> Signed-off-by: Nishanth Menon<nm at ti.com>
>> ---
>>   arch/arm/mach-omap2/smartreflex.c |    2 +-
>>   1 files changed, 1 insertions(+), 1 deletions(-)

>> diff --git a/arch/arm/mach-omap2/smartreflex.c 
>> b/arch/arm/mach-omap2/smartreflex.c
>> index 99e4c4f..a4e9f2d 100644
>> --- a/arch/arm/mach-omap2/smartreflex.c
>> +++ b/arch/arm/mach-omap2/smartreflex.c
>> @@ -278,7 +278,7 @@ static int sr_late_init(struct omap_sr *sr_info)
>>               goto error;
>>           }
>>           ret = request_irq(sr_info->irq, sr_interrupt,
>> -                0, name, (void *)sr_info);
>> +                IRQF_DISABLED, name, (void *)sr_info);

>    Isn't this flag a nop now?

    Indeed, it is, according to the comment in <linux/interrupt.h>. So what does 
this patch really achieve?

WBR, Sergei




More information about the linux-arm-kernel mailing list