[PATCH 1/5] ARM: mx35_3ds: Add I2C support

[Jason Liu]

Hi, Uwe,

2011/3/2 Uwe Kleine-König <u.kleine-koenig at pengutronix.de>:
> Hello,
>
> On Tue, Mar 01, 2011 at 04:59:44PM -0300, Fabio Estevam wrote:
>> +     imx35_add_imx_i2c0(&mx35_3ds_i2c0_data);
> I'd slightly prefer using
>
>        imx35_add_imx_i2c(0, ...)
>
> because I intend to remove the imx35_add_imx_i2c0-like macros soon.  But

Could you please explain why you intend to remove
imx35_add_imx_i2c0-like macros?
What you would like to do instead? Thanks,

> if nothing else pops up there is no need to respin the series because of
> that.
>
> Other than that all 5 patches look good;
>        Acked-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
>
> Best regards
> Uwe
>
> --
> Pengutronix e.K.                           | Uwe Kleine-König            |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>