[PATCH 2/4] msm: scm: Fix improper register assignment
nico at fluxnic.net
Tue Mar 1 19:02:27 EST 2011
On Tue, 1 Mar 2011, Saravana Kannan wrote:
> On 03/01/2011 02:37 AM, Will Deacon wrote:
> > Perhaps a more robust fix would be to remove the register int
> > declarations and handle the parameter marshalling in the same asm block
> > that contains the smc?
> I was thinking the same, but the opposing idea I heard was that not doing it
> inside the asm block would allow GCC to be make better use of the registers.
Indeed. And a significant body of code out there does rely on this gcc
feature, so it has to minimally work.
> Didn't have a strong opinion either way, so we went with the implementation
> that was sent out.
More information about the linux-arm-kernel