[PATCH v7 1/1] PRUSS UIO driver support
Hans J. Koch
hjk at hansjkoch.de
Tue Mar 1 17:22:29 EST 2011
On Tue, Mar 01, 2011 at 10:45:25PM +0100, Thomas Gleixner wrote:
>
> > +
> > + spin_lock_init(&lock);
>
> Sigh. DEFINE_SPINLOCK(lock); already initializes the lock.
>
> It's not the purpose of a review to tell you what you need to change
> mechanically. Reviewers hint to a correct solution and you are
> supposed to lookup what that solution means and act accordingly. If
> you do not understand the hint or its implications please ask _before_
> sending a new patch set.
Correct. But I'm to blame here, too, since I suggested the wrong solution.
Sorry for that, Gangadhar!
Thanks,
Hans
More information about the linux-arm-kernel
mailing list