[PATCH] gpio: ep93xx: move driver to drivers/gpio

[Kyungmin Park]

On Thu, Jun 2, 2011 at 2:24 AM, H Hartley Sweeten
<hartleys at visionengravers.com> wrote:
> On Wednesday, June 01, 2011 9:46 AM, Grant Likely wrote:
>> On Wed, Jun 1, 2011 at 2:26 AM, Russell King - ARM Linux wrote:
>>> On Tue, May 31, 2011 at 05:28:26PM -0600, Grant Likely wrote:
>>>>> [...]Should I change this to:
>>>>>
>>>>> +config GPIO_EP93XX
>>>>> +       bool
>>>>> +       depends on ARCH_EP93XX
>>>>> +       default y
>>>>>
>>>>> Or like the Samsung drivers, without the visibility:
>>>>>
>>>>> +config GPIO_EP93XX
>>>>> +       bool
>>>>> +       depends on ARM
>>>>> +       default y if ARCH_EP93XX
>>>>
>>>> I like the former.
>>>
>>> Even better is:
>>>
>>> config GPIO_EP93XX
>>>        def_bool y
>>>        depends on ARCH_EP93XX
>>
>> Yup.
>
> Shouldn't the Samsung gpio drivers be handled the same way?
>
> Also, the depends on ARM is redundant.  The other symbols are only
> available when ARM is defined.
>
> Something like this.
>
>
> gpio: Samsung: make Kconfig options def_bool
>
> The Samsung GPIO drivers are always built-in when the relevant
> platform is selected.  Change the Kconfig symbol to def_bool y
> dependant on the platform.
>
> Signed-off-by: H Hartley Sweeten <hsweeten at visionengravers.com>
>
> ---
>
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 18c0b31..2e3cd11 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -87,32 +87,20 @@ config GPIO_IT8761E
>          Say yes here to support GPIO functionality of IT8761E super I/O chip.
>
>  config GPIO_EXYNOS4
> -       bool "Samsung Exynos4 GPIO library support"
> -       default y
> -       depends on ARM && CPU_EXYNOS4210
> -       help
> -         Say yes here to support Samsung Exynos4 series SoCs GPIO library
> +       def_bool y
> +       depends on CPU_EXYNOS4210
>
>  config GPIO_PLAT_SAMSUNG
> -       bool "Samsung SoCs GPIO library support"
> -       default y
> -       depends on ARM && SAMSUNG_GPIOLIB_4BIT
> -       help
> -         Say yes here to support Samsung SoCs GPIO library
> +       def_bool y
> +       depends on SAMSUNG_GPIOLIB_4BIT
>
>  config GPIO_S5PC100
> -       bool "Samsung S5PC100 GPIO library support"
> -       default y
> -       depends on ARM && CPU_S5PC100
> -       help
> -         Say yes here to support Samsung S5PC100 SoCs GPIO library
> +       def_bool y
> +       depends on CPU_S5PC100
>
>  config GPIO_S5PV210
> -       bool "Samsung S5PV210/S5PC110 GPIO library support"
> -       default y
> -       depends on ARM && CPU_S5PV210
> -       help
> -         Say yes here to support Samsung S5PV210/S5PC110 SoCs GPIO library
> +       def_bool y
> +       depends on CPU_S5PV210
>

Acked-by: Kyungmin Park <kyungmin.park at samsung.com>

>  config GPIO_PL061
>        bool "PrimeCell PL061 GPIO support"
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>