[PATCH] gpio/mxc/mxs: fix build error introduced by the reanming of irq_gc_ack()

Uwe Kleine-König u.kleine-koenig at pengutronix.de
Tue Jul 19 11:23:23 EDT 2011


Hello Shawn,

> > >  	ct = gc->chip_types;
> > >-	ct->chip.irq_ack = irq_gc_ack,
> > >+	ct->chip.irq_ack = irq_gc_ack_set_bit,
> > 
> >    There should be semicolon rathern than comma at the end.
> > 
> Thanks, Sergei.  I'm pretty surprised that gcc did not help me there.
> > >  	ct->chip.irq_mask = irq_gc_mask_clr_bit;
That's because using a comma is valid C, too.
It just assigns ct->chip.irq_ack as a side effect of the
expression

	ct->chip.irq_ack = irq_gc_ack_set_bit, ct->chip.irq_unmask = irq_gc_mask_set_bit;

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |



More information about the linux-arm-kernel mailing list