[PATCH V2 12/12] ASoC: Samsung: Update DMA interface

Kukjin Kim kgene.kim at samsung.com
Fri Jul 15 20:01:40 EDT 2011


Mark Brown wrote:
> 
> On Wed, Jul 13, 2011 at 05:47:37PM +0900, Kukjin Kim wrote:
> 
> > -static inline bool s3c_dma_has_circular(void)
> > +static inline bool dma_has_circular(void)
> >  {
> >  	return false;
> >  }
> 
> The namespacing here doesn't look great, this is still a Samsung
> specific internal API.
> 

OK, will keep it.

> Otherwise this looks good.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim at samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.




More information about the linux-arm-kernel mailing list